mpv-player / mpv-player/mpv

Screenshots are scaled for non-square pixel sources

Open
#11,857 16 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

vo:gpu vo:gpu-next
Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

Important Information

Screenshots are scaled for non-square pixel sources but should not, as is indicated in the documentation: A screenshot will usually contain the unscaled video contents at the end of the video filter chain and subtitles.

Information:

  • mpv version : 0.35.1
  • Platform and Version : macos 12.6.6
  • Source of the mpv binary : homebrew cask
Reproduction steps
  1. Open a video with non-square pixels (from command line or bundle app).
  2. Take a screenshot (by pressing "s").
  3. Compare the real pixel resolution of the video with the one of the image, they should be identical but they are not.
Expected behavior

The screenshot should have the same resolution as the raw resolution of the video, not the same as the display resolution.

Actual behavior

The screenshot have the same resolution as the displayed resolution of the video, not the same as the raw pixel resolution.

Notes

For example, if I open a video file with non-square pixels with a resolution of 720x486, displayed at 720x540 (4:3), the screenshot have a resolution of 720x540 instead of 720x486. The problem was not present in previous versions but unfortunately I dont know when the change appears. Currently, as a workaround, I'm using video-aspect-override=no in the conf.

Log file

output.txt

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce with a 720x486 video using non-square pixels, press "s", and compare the screenshot dimensions with the raw video dimensions. Use the documented behavior and the video-aspect-override=no workaround as references; done means screenshots retain the raw resolution rather than the displayed 720x540 resolution.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.