mpv-player / mpv-player/mpv

Watch-later from fullscreen window contains wrong border information

Open
#11,575 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

os:linux vo:gpu:wayland
Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

Important Information

Provide following Information:

  • mpv 0.35.0-363-gc50f536bd1
  • Arch Linux
  • compiled from source
  • KDE Plasma 5.27.4 on Wayland
  • Mesa 23.0.2
Reproduction steps
  1. Create a directory with a mpv.conf containing border=no
  2. mpv --config-dir=<path to aforementioned directory> <path to some video file>
  3. Fullscreen the video
  4. Quit with Shift+q to save watch-later information
  5. Run the same mpv command again
  6. Exit fullscreen
Expected behavior

Window has no border

Actual behavior

Window has a border.

The file with the watch-later information (~~/watch-later/<hash>) contains border=yes instead of border=no.

Log file

log from first run
log from second run

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the linked first-run and second-run logs with the saved watch-later file under ~~ /watch-later/, focusing on how fullscreen state affects the saved border value. Reproduce the six listed steps and confirm that a configuration with border=no still restores without a border after leaving fullscreen.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.