mpv-player / mpv-player/mpv

[auto_profiles.lua] the script incorrectly gets the value of `audio-params/channel-count`

Open
#11,541 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

Important Information

Provide following Information:

Reproduction steps

I'm using two profiles.

[louder_speaking]
profile-cond=p["audio-params/channel-count"]>2
af-pre=@vocal:loudnorm

[louder_speaking-alt]
profile-cond=p["audio-params/channel-count"]<=2
af-remove=@vocal
Expected behavior

work as expectation with the option --audio-channels.

Actual behavior

If using audio-channels = stereo in mpv conf.
The script would sometimes get the value of 2 (for my conditions)

Log file

test.log

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading auto_profiles.lua and reproduce the reported profile behavior with audio-channels = stereo and the two profile conditions from the issue. Use the linked test.log and compare the channel-count value observed by the script with the expected value; done means the profiles respond correctly to --audio-channels.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
audio-video-rtc, cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.