mpv-player / mpv-player/mpv

Subtitle upscaling causes frame drops

Open
#11,511 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

core:subtitle os:win
Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

Important Information
  • mpv version
mpv 0.35.0-339-gd1d0b1a8 Copyright © 2000-2023 mpv/MPlayer/mplayer2 projects
 built on Tue Mar 28 12:41:04 2023
libplacebo version: v5.264.0-85-g0f36b01
FFmpeg version: N-110105-g9bf1848ac
FFmpeg library versions:
   libavutil       58.5.100
   libavcodec      60.7.100
   libavformat     60.4.100
   libswscale      7.2.100
   libavfilter     9.5.100
   libswresample   4.11.100
  • Windows Version
Edition	Windows 10 Pro
Version	22H2
Installed on	‎19/‎03/‎2023
OS build	19045.2728
Experience	Windows Feature Experience Pack 120.2212.4190.0
Reproduction steps

mpv --no-config --fs --log-file=Example1-0005.txt --gpu-debug --vo=gpu-next --gpu-api=vulkan Example1-0005.m2ts
Use mpv to play 1080p video file with subtitles on a 4k display using gpu-next and gpu-api=vulkan.
This issue seems to not exist if playing on a 1080p display, which makes me think that subtitle upscaling is the trigger.
Example 1: Issue starts from 00:05 (5 seconds in the video).
Example 2: Issue starts from 03:32.
Example 3: Issue starts from 16:33, this case is the worst, no subtitles visible on the screen and so many frame drops.

Expected behavior

No frame drops.

Actual behavior

Frame drops.

Log file

Example1-0005.txt
Example2-0332.txt
Example3-1633.txt

Sample files

Subtitle file:
Example1-0005.zip
Example2-0332.zip
Example3-1633.zip

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the provided mpv command using gpu-next, Vulkan, a 4K display, and the linked sample files. Start by comparing Example1-0005.txt, Example2-0332.txt, and Example3-1633.txt around their reported timestamps. Done means identifying and addressing the subtitle-upscaling condition so playback has no frame drops.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
desktop, performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.