mpv-player / mpv-player/mpv

.ass file using UTF-16LE encoding with a BOM cannot be detected

Open
#11,482 12 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

down-upstream:ffmpeg os:win
Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

The following is an example file:

[WLGO&PPX][Itazura_na_Kiss][DVDRip][05][x264_AAC][880x480][FB7AD9EF].gb.zip

After saving as a file using e.g. UTF-8 encoding, the problem disappears, but it'll be more convenient if UTF-16LE with a BOM is supported.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with the linked example file in mpv on Windows 10, then trace the subtitle format-detection and encoding-handling entry points. The work is done when an .ass subtitle encoded as UTF-16LE with a BOM is detected and handled without requiring conversion to UTF-8.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
audio-video-rtc
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.