mpv-player / mpv-player/mpv

frame-step and frame-back-step does not work consistently when beyond a video stream

Open
#11,471 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

Important Information

Provide following Information:

  • mpv version 0.35.1
  • Platform and Version Linux Manjaro 22.0.5
  • Source of the mpv binary pacman

If you're not using git master or the latest release, update.
Releases are listed here: https://github.com/mpv-player/mpv/releases

Reproduction steps

Try to reproduce your issue with --no-config first. If it isn't reproducible
with --no-config try to first find out which option or script causes your issue.

Describe the reproduction steps as precise as possible. It's very likely that
the bug you experience wasn't reproduced by the developer because the workflow
differs from your own.

  • open a file which has longer audio than a video stream
  • try the various methods from "actual behavior"
  • observe inconsistent behavior
Expected behavior

that it works consistently

Actual behavior
  • when going into the area after the video stream and still holding it down (frame-step) when going into "beyond" area, it skips correctly
  • when using frame-step or frame-back-step in a "beyond" area, it advanced very slowly for one press
  • holding down frame-step (not frame-back-step) when in a beyond area advances the time like being in a video stream
  • holding down frame-back-step (not frame-step) is very slow in stepping back time or does nothing at all
Log file

mpv.log

Sample files

Sample file 5 second of black video, and 10 seconds of silence audio


using default key-bindings . and ,

also note that when using frame-step in a "beyond" area, the log does not output much, but using frame-back-step repeatably outputs "video EOF" logs

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with --no-config using the linked sample file, the default . and , bindings from etc/input.conf, and the attached log. Compare held and single-press frame-step and frame-back-step behavior before and after the video stream, including the video EOF messages. Done means stepping behaves consistently in the beyond-video area.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.