vo_gpu-next: `--hdr-compute-peak=yes` should ignore the dovi metadata.
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 37k
- Forks
- 3.5k
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 22
Description
Important Information
Provide following Information:
- mpv version
https://github.com/mpv-player/mpv/commit/d1cf89b65554d6501fe62cc0989fab97180b8377 - Platform and Version
win10 pro 22H2 - Source of the mpv binary
https://github.com/zhongfly/mpv-winbuild/releases/tag/2023-02-20
Reproduction steps
Load any dovi video and set hdr-compute-peak=yes
Expected behavior
https://mpv.io/manual/master/#options-hdr-compute-peak
Compute the HDR peak and frame average brightness per-frame instead of relying on tagged metadata.
I do not want use dovi's RPU metadata.
Actual behavior
cycle hdr-compute-peak but nothing would help.
Log file
I think it was an oversight in design that introduced by recent commits https://github.com/mpv-player/mpv/commit/41ad51bda281e56ddc8bb4416b82b47903e779f1
Sample files
N/A
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the hdr-compute-peak option in the mpv manual and compare the behavior introduced by commits 41ad51bda281e56ddc8bb4416b82b47903e779f1 and d1cf89b65554d6501fe62cc0989fab97180b8377. Trace how Dolby Vision RPU metadata is handled when peak computation is enabled; done means hdr-compute-peak=yes computes peak and frame-average brightness without relying on that metadata.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100