mpv-player / mpv-player/mpv

Frame stepping is broken with gpu-next and interpolation

Open
#11,048 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

os:win
Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

The issue should be the same bug as #10107, however it shows a more broken output, and it adds Windows as another reproducible platform

Important Information

Provide following Information:

  • mpv version
mpv 0.35.0-62-gcb15bc4324 Copyright © 2000-2022 mpv/MPlayer/mplayer2 projects
 built on Sun Dec 25 12:21:50 2022
libplacebo version: v5.229.1-49-g22ce304
FFmpeg version: git-2022-12-24-f8a2a6507
FFmpeg library versions:
   libavutil       57.43.100
   libavcodec      59.55.103
   libavformat     59.34.102
   libswscale      6.8.112
   libavfilter     8.53.100
   libswresample   4.9.100
  • Windows Version - Win 11 22H2
  • Source of the mpv binary - Shinchiro x64v3
  • If known which version of mpv introduced the problem - Unknown
  • Possible screenshot or video of visual glitches

https://user-images.githubusercontent.com/22327220/209504149-39b5a054-ace2-43c0-9678-7b1c985c5d49.mp4

If you're not using git master or the latest release, update.
Releases are listed here: https://github.com/mpv-player/mpv/releases

Reproduction steps
  1. ffmpeg -f lavfi -i testsrc=duration=10:size=1280x720:rate=24:n=2 testsrc.mkv
  2. mpv testsrc.mkv --no-config --vo=gpu-next --video-sync=display-resample --interpolation --log-file=framesteplog.txt
  3. Hover onto OSC as it forces frame refresh
  4. Press . and , to frame-step.
Expected behavior

Normal frame-stepping

Actual behavior

It will either stay on the same frame or skip 2 frames. frame-backstepping back steps successfully before it gets refreshed back to the old frame due to OSC forcing a refresh

Log file

framesteplog.txt

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with the provided ffmpeg testsrc command and the mpv gpu-next, display-resample, and interpolation options, then compare the behavior and log with issue #10107. Done means frame-stepping advances or reverses exactly one frame without OSC-triggered refreshes restoring or skipping frames.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
audio-video-rtc, computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.