mpv-player / mpv-player/mpv

With both "fullscreen=yes" and "window-maximized" in mpv.conf, exiting fullscreen does not maximize the window

Open
#10,229 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

os:linux
Dominant language
C
Stars
37k
Forks
3.5k
Avg merge
1d 10h
Merged PRs (30d)
22

Description

Provide following Information:

  • mpv version mpv 0.34.0-UNKNOWN Copyright © 2000-2022 mpv/MPlayer/mplayer2 projects
    built on Tue May 3 23:24:39 EDT 2022
  • Linux Distribution and Version Linux Mint 20.3 XFCE
  • Source of the mpv binary I just followed the instructions on this SVP wiki page to compile mpv+vapoursynth from source because I needed vapoursynth support; I also made sure to install the libicu-le-hb-dev package before compiling since, without it, compilation would fail on Mint 20.1 and I didn't feel like risking that on 20.3
  • Window Manager and version: whatever comes with Mint 20.3 XFCE by default
  • GPU driver and version: 21.2.6-0ubuntu0.2~20.04.2 on Ryzen 4800U integrated graphics

UPDATE: This issue occurs even in a live session booted from the Xubuntu 22.04 ISO using the standard 0.34.1 mpv installed from Xubuntu's "Software" application.

Reproduction steps

Really simple, just have both fullscreen=yes and window-maximized in your mpv.conf file; they can even be the only things in the entire mpv.conf file.

Expected behavior

The video should start in fullscreen and then, if/when you exit fullscreen without closing mpv, mpv's program window displaying the video should be maximized.

Actual behavior

The video starts in fullscreen but, if/when you exit fullscreen without closing mpv, mpv's program window is not maximized and it is instead sized at whatever resolution the current playing video is.

It may at least be worth mentioning that window-maximized does in fact work if fullscreen=yes is not present in your mpv.conf file.

Log file

output.txt

Sample files

Occurs with any file, but will not be noticeable unless the video file has a resolution that is substantially different from your display (e.g. with a 1080p display, you need to use a 720p video or a 1440p video; it's also particularly easy to notice with a "vertical video")

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the behavior with only fullscreen=yes and window-maximized in mpv.conf, using a video whose resolution differs substantially from the display. Start by reviewing output.txt and the window-state handling; done means exiting fullscreen leaves the mpv window maximized rather than resized to the video's resolution.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, linux
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.