apply-profile-cond to respect condition in auto-profiles when used from input.conf
Open
Nobody has claimed this yet.
meta:feature-request
- Dominant language
- C
- Stars
- 37k
- Forks
- 3.5k
- Avg merge
- 1d 10h
- Merged PRs (30d)
- 22
Description
It would be useful if one could do the following:
mpv.conf:
[add-sharpness]
profile-cond=(width < 2560 and height < 1440) # Display size (aka. if any type of up-scaling is used)
glsl-shader="~~/shaders/adaptive-sharpen-0_1.glsl"
input.conf:
CTRL+1 no-osd change-list glsl-shaders clr ""; no-osd change-list glsl-shaders append "~~/shaders/FSRCNNX_x2_8-0-4-1.glsl"; no-osd change-list glsl-shaders append "~~/shaders/KrigBilateral.glsl"; apply-profile add-sharpness; show-text "Shaders: FSRCNNX + Krig (Default)"
apply-profile as is right now does not care about the condition it just applies the profile.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the behavior with the shown mpv.conf profile and input.conf binding, then trace how apply-profile handles profile-cond and auto-profiles. Done means invoking apply-profile from input.conf evaluates the profile condition instead of applying the profile unconditionally, while preserving the demonstrated shader workflow.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- cli
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100