mozilla / mozilla/readability

Wikipedia's h2s aren't included.

Open
#986 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

has-website-testcase reader-mode-has-issues top-website-issue
Dominant language
JavaScript
Stars
11.5k
Forks
732
PR merge metrics
No merged PRs in 30d

Description

Wikipedia's h2s are wrapped in a div that also includes edit and talk links. This seems to confuse Readability somehow, so that it doesn't include them.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue on a Wikipedia page with level-two headings, then trace Readability's heading extraction and how the surrounding div is handled. Done means Wikipedia h2 headings are included while the associated edit and talk links are not.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.