reader view works for the URL mentioned below, except for some lines that are not displayed. Perhaps because of an embedded JavaScript

Open
#754 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
web-dev

Research direction

Start by reproducing Reader View on the linked DigitalOcean article and compare the source with the extracted content, focusing on the final section containing the #!/bin/bash script and its copy button. Done means the script lines appear in Reader View without omitting the surrounding article content.

Written by the indexing model from the issue text.

Description

has-website-testcase

(Filing on behalf of user u34. Copied verbatim from https://bugzilla.mozilla.org/show_bug.cgi?id=1770613 where it was originally filed.)

image

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

The problem was also seen with a vanilla Firefox 100.0.2(64-bit) Linux desktop.
I am not sure if the issue was not mentioned in the list of related bugs that was presented to me before entering this text. It could be I have not enough technical knowledge to spot that it was mentioned.
I am also not sure this is not an enhancement, or a partial enhancement, request.
The related URL is https://www.digitalocean.com/community/tutorials/how-to-set-up-dnssec-on-an-nsd-nameserver-on-ubuntu-14-04. I could not spot other lines of the URL that are missing in the reader view page, other then the lines I mentioned below. I believe there are not other missing lines. The section that I have spotted the missing lines in seem to be different then the other sections of the article. It could be the difference is the key for the missing lines.
The attached 2 pictures are from the last few lines of the article. I will probably upload 1 of the 2 separately from submitting this this text, because I can not see a way to upload 2 pictures at once. By comparing those 2 pictures, the problem seem to me obvious. What I think is the key difference from the other parts of the article is the copy button, at the top right corner of the non reader view display.

Actual results:

The lines that constitutes the #!/bin/bash script were not displayed in reader view.

Expected results:

The lines that constitutes the #!/bin/bash script should have been displayed in reader view.

Dominant language
JavaScript
Stars
11.5k
Forks
732
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mozilla/readability

All issues in mozilla/readability

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.