Remove Font Awesome icons

Open
#556 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
web-dev

Research direction

Reproduce parsing of the linked article and inspect the HTML parsing path that leaves the Font Awesome span in the output. Check how both span and i Font Awesome syntaxes are represented, then verify that icon elements are removed without affecting legitimate classes with similar names.

Written by the indexing model from the issue text.

Description

images

For example after parsing of this article span of an icon is left in html.

<span class="fa fa-search-plus full-image" data-src="https://static2.gazeta.ua/img2/cache/gallery/924/924461_1_w_1200.jpg?v=0" data-caption="">

Font Awesome has different syntaxes, eg: <i class="fas fa-pen-fancy"></i>

A hacky solution can be removal of any element which contains ' fa-' in className. My only concern is that it may affect other legitimate elements with similar class names, although it will be very rare.

Dominant language
JavaScript
Stars
11.5k
Forks
732
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mozilla/readability

All issues in mozilla/readability

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.