New York Times glossary spans should be removed from reader mode

Open
#540 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
web-dev

Research direction

No source file or test is named. Start with the New York Times HTML example and the linked Bugzilla report, then identify where reader mode processes the glossary-wrapper markup; done means glossary-info content is absent from the resulting reader view while the glossary-text remains.

Written by the indexing model from the issue text.

Description

has-website-testcase reader-mode-has-issues top-website-issue

From https://bugzilla.mozilla.org/show_bug.cgi?id=1544594

Some NYT articles include markup like this:

<span class="glossary-wrapper">
<span class="glossary-text">transparency</span>
<span class="glossary-info">
<span class="glossary-definition">Taking appropriate measures to provide any information relating to processing to the data subject in a concise, intelligible and easily accessible form, using clear and plain language. <a href="https://www.nytimes.com/interactive/2019/04/10/opinion/internet-privacy-terms.html" target="_blank">Glossary</a>
</span><img class="close-tooltip" src="https://static01.nyt.com/newsgraphics/2019/01/22/tooltip-template/1e41ab3eab12f1354e056fb2fa3acc6d09df13e2/close.svg" alt="Close X">
</span><span></span></span>

We should be removing the glossary-info bits.

Dominant language
JavaScript
Stars
11.5k
Forks
732
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mozilla/readability

All issues in mozilla/readability

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.