Better handling of `<aside>` content

Open
#487 9 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
web-dev

Research direction

Review the behavior and rationale in pull request 431, then compare the linked HPBN and Engadget examples against the HTML5 Doctor guidance. Determine how nested and unrelated aside content should be classified, and validate the chosen behavior against both examples before considering the issue done.

Written by the indexing model from the issue text.

Description

has-website-testcase reader-mode-has-issues

As per this article, an <aside> inside an <article> should be treated as part of the content. In @andreskrey's Pull request all aside elements are removed, and articles such as this get useful content removed.

Unfortunately, it seems Engadget uses asides in the <article> tag for content unrelated to the article... so I'm not sure how a good solution would look like.

Dominant language
JavaScript
Stars
11.5k
Forks
732
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mozilla/readability

All issues in mozilla/readability

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.