Missing content on article generated with Microsoft FrontPage

Open
#388 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
content

Research direction

Reproduce the issue at http://www.cosmoetica.com/B480-DES412.htm in Reader View and inspect the debug output for the “Removing unlikely candidate - MsoHeader” messages. Compare the FrontPage-generated HTML with the extracted article content; done means the article text is retained without broadly weakening the unlikely-candidate heuristic.

Written by the indexing model from the issue text.

Description

has-website-testcase reader-mode-has-issues
  1. Go here: http://www.cosmoetica.com/B480-DES412.htm
  2. Enter Reader View
  3. Most of the article text has been lost. Only the final paragraph survives.

I ran readability in debug mode on the same page, and it prints a bunch of output like this:

Reader: (Readability)  { '0': 'Removing unlikely candidate - MsoHeader ' }
Reader: (Readability)  { '0': 'Removing unlikely candidate - MsoHeader ' }
Reader: (Readability)  { '0': 'Removing unlikely candidate - MsoHeader ' }
...

Looking at the input HTML, it turns out that most of the article text is within <p class="MsoHeader"> tags.

<p class="MsoHeader" style="tab-stops: .5in; margin-top: 0; margin-bottom: 0"><span style="mso-spacerun: yes">&nbsp;
</span><i>Persona</i>, Ingmar Bergman’s 1966 black and white film, reminds me
of Herman Hesse’s novella <i>Siddhartha</i>. Not in the subject matter, but in
that both works of art perfectly marry their messages with their forms, and both
say so much with so little a narrative spine. In that sense, both are great ...
</p>

I'm not really familiar with Office-generated HTML, but I did notice other pages from this website which have the same problem.

Maybe the "unlikely candidate" heuristic should make an exception for "MsoHeader".

Dominant language
JavaScript
Stars
11.5k
Forks
732
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mozilla/readability

All issues in mozilla/readability

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.