Sidemenu JS should not add aria-expanded="false" to .mzp-c-sidemenu-main
Nobody has claimed this yet.
- Dominant language
- SCSS
- Stars
- 298
- Forks
- 83
- Avg merge
- 16h 48m
- Merged PRs (30d)
- 1
Description
Description
Similar to https://github.com/mozilla/protocol/issues/847, the aria-expanded attribute is being applied incorrectly to the side menu component.
This role should be declared on a controlling element like a button or link and must be used with aria-controls. Also, on desktop this content is expanded by default so it should not be false.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the sidemenu JavaScript and the .mzp-c-sidemenu-main element, then compare the behavior with related issue 847. Verify how aria-expanded is applied and how the desktop state is represented. Done means the attribute is no longer incorrectly applied to the main content and the desktop content remains expanded by default.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- accessibility, frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100