Consolidate focus ring styles/colors
Nobody has claimed this yet.
- Dominant language
- SCSS
- Stars
- 298
- Forks
- 83
- Avg merge
- 16h 48m
- Merged PRs (30d)
- 1
Description
Some elements, namely buttons and form fields, get a colored halo when they receive focus. There are a few different styles defined in https://github.com/mozilla/protocol/blob/main/assets/sass/protocol/includes/forms/_index.scss#L31-L35
We should unify focus styles for consistency across elements, and probably prefer opaque token colors rather than mixing or transparent. We may still want a different color for light and dark themes.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in assets/sass/protocol/includes/forms/_index.scss at lines 31-35 and compare the focus styles applied to buttons and form fields. Identify the existing ring styles and colors, then define the consistency goal for light and dark themes and opaque token usage. Done means the affected elements use unified focus styling without losing theme-specific needs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scss
- Domain
- accessibility, design
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100