mozilla / mozilla/protocol

[Component Change Request] Improve layout around form inputs

Open
#887 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
SCSS
Stars
298
Forks
83
Avg merge
16h 48m
Merged PRs (30d)
1

Description

The default CSS for form elements could do with a couple of tweaks around error state handling, showing and hiding of form fields when using the newsletter JS from Bedrock and the multi-checkbox layout.

These have been done as part of mozmeao/birdbox, but worth backporting:

https://github.com/mozmeao/birdbox/blob/main/src/css/birdbox-protocol-overrides.scss

Before the tweaks

ad-hoc-form

After the tweaks

Screenshot 2023-07-10 at 16-12-57 Protocol Components Test Page - Local dev test site

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/css/birdbox-protocol-overrides.scss in the linked birdbox reference and compare its form overrides with the protocol component CSS. Verify the error state, Bedrock newsletter field visibility, and multi-checkbox layout against the supplied before-and-after screenshots; done means those three cases match the intended result.

Written by the indexing model from the issue text.

Assessment

Tech stack
scss
Domain
design, frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.