Modal styles assume light color themed links
Nobody has claimed this yet.
- Dominant language
- SCSS
- Stars
- 298
- Forks
- 83
- Avg merge
- 16h 48m
- Merged PRs (30d)
- 1
Description
Description
The current modal styles seem to assume that all links contained within the modeal will be light color themed. This can cause issues on links that appear on dark backgrounds, or use colored buttons.
Ref: https://github.com/mozilla/protocol/blob/main/src/assets/sass/protocol/components/_modal.scss#L105
Steps to reproduce
See https://github.com/mozilla/bedrock/issues/9866
Expected result
We probably shouldn't make an assumption about the content within the modal?
Actual result
It is assumed that links will all appear on a light background.
Environment
Firefox 95
macOS
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/assets/sass/protocol/components/_modal.scss at the referenced line, then review the reproduction in mozilla/bedrock#9866. Check how modal links are styled on dark backgrounds and colored buttons. Done means modal content no longer assumes every link is on a light background.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scss
- Domain
- design, frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100