Refactor notification bar 'close' function for IE support
Open
Beginner friendly
Nobody has claimed this yet.
Bug :beetle:
Size: XS
- Dominant language
- SCSS
- Stars
- 298
- Forks
- 83
- Avg merge
- 16h 48m
- Merged PRs (30d)
- 1
Description
Description
In #534 it was noted that the function to close the notification bar is not supported in IE.
e.currentTarget.parentNode.remove(), we should refactor this to removeChild()
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the notification bar implementation for e.currentTarget.parentNode.remove() and inspect the surrounding close handler. Replace the unsupported removal call with the requested removeChild() approach, then verify that closing the notification bar still works in the supported browsers, especially IE.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100