mozilla / mozilla/protocol

Verify eslint-env inline configuration comments/globals are still necessary

Open
#1,121 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
SCSS
Stars
298
Forks
83
Avg merge
16h 48m
Merged PRs (30d)
1

Description

Before upgrading to ESLint v10 there will be a few warnings to look into. Apparently eslint-env comments in the webpack configs are still considered part of the eslintrc (non-flat) era:

ESLintEnvWarning: /* eslint-env */ comments are no longer recognized when linting with flat config and will be reported as errors as of v10.0.0. Replace them with /* global */ comments or define globals in your config file. See https://eslint.org/docs/latest/use/configure/migration-guide#eslint-env-configuration-comments for details.

Quickly checking I think these are already correctly configured in the right places from when Alex migrated to the new config style, so it may just be as simple as removing these remnants — but I'll cross-reference the values and environments first, to check it's actually 1:1 mapped already, or there are deviations worth mentioning.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect the webpack configuration files and the current flat ESLint configuration. Cross-reference each eslint-env comment's environments and globals, remove only comments that are already represented elsewhere, and verify that the warnings no longer occur before the ESLint v10 upgrade.

Written by the indexing model from the issue text.

Assessment

Tech stack
webpack
Domain
build-system, tooling
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.