Update buttons with icons wrapping style
Nobody has claimed this yet.
- Dominant language
- SCSS
- Stars
- 298
- Forks
- 83
- Avg merge
- 16h 48m
- Merged PRs (30d)
- 1
Description
As noted in this PR comment: https://github.com/mozmeao/springfield/pull/897#issuecomment-3785835715
Need to consult with design on what the ideal default behaviour would be when buttons with icons wrap. Confirm if this is a download-button-specific case or general use.
text wrap balance (keeping current inline-block display)
change to flex display, no shrink and center align on icon
...something else?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked PR comment and the supplied screenshots to understand the current icon-button wrapping cases. Consult design to decide whether the behavior is download-button-specific or general, then validate the chosen wrapping behavior for buttons with icons.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scss
- Domain
- design, frontend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100