mozilla / mozilla/protocol

Add loading state to newsletter

Open
#1,102 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
SCSS
Stars
298
Forks
83
Avg merge
16h 48m
Merged PRs (30d)
1

Description

Description

We used inline SVGs for loading indicator on recent newsletter updates. Use of a style tag for animation in this SVG created CSP errors (in console and on Sentry)

Bedrock: https://github.com/mozilla/bedrock/blob/main/bedrock/newsletter/templates/newsletter/includes/form.html#L114

Related

https://github.com/mozmeao/springfield/issues/785

Success Criteria

  • newsletter component includes user-facing loading indicator
  • no CSP errors

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the referenced Bedrock template at bedrock/newsletter/templates/newsletter/includes/form.html around line 114, and review related issue springfield#785 for context. Update the newsletter component so it has a user-facing loading indicator without causing CSP errors, then verify both success criteria.

Written by the indexing model from the issue text.

Assessment

Tech stack
scss
Domain
frontend, security
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.