Protocol v23
Open
Nobody has claimed this yet.
- Dominant language
- SCSS
- Stars
- 298
- Forks
- 83
- Avg merge
- 16h 48m
- Merged PRs (30d)
- 1
Description
We're going to do some major renovations to improve maintainability.
- Rename "title" to "heading"
- Rename "desc" to "body"
- Use CSS logical properties (start/end and block/inline)
- Rename classes and mixins to reflect logical names
- Standardize our focus support by using :focus-visible instead of :focus.
- Fix the Sass mixed-decls warnings and un-pin the Sass version
Once that's done before publishing we need to:
- Review the unsupported experience and give it some basic styles/support.
- Make sure the Firefox theme didn't get broken.
Existing issues (not all the work is in issues yet)
Modernizing:
- https://github.com/mozilla/protocol/issues/982 (note: I don't think we need to have removing the Sass variables as a goal for V23 for values that do not morph)
- https://github.com/mozilla/protocol/issues/998
- https://github.com/mozilla/protocol/pull/1107/
- https://github.com/mozilla/protocol/issues/957
Renaming: - https://github.com/mozilla/protocol/issues/668
- https://github.com/mozilla/protocol/issues/448
- https://github.com/mozilla/protocol/issues/701
Finished work
- #1114
- #1113
- #1110
- #1109
- #1107
- https://github.com/mozilla/protocol/pull/1117
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.