We should check for duplicate ping definitions as well as duplicate metric definitions

Open
#871 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
data

Research direction

Start by locating the existing duplicate metric definition check and the schema generator referenced in the issue. Add equivalent detection for duplicate ping definitions, then verify that duplicate names are reported before schema generation with useful context and tests.

Written by the indexing model from the issue text.

Description

At present we check for duplicate metric definitions, but we don't check for duplicate ping definitions.

We kinda-sorta have schema generator keeping an eye on this because trying to create two tables with the same names but different columns will bork pretty hard, but catching things here would catch things earlier. And it's considered best practice to catch things earlier (not leastwise because we'll have better context to make better error messages).

Dominant language
Python
Stars
26
Forks
73
Avg merge
10h
Merged PRs (30d)
3

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mozilla/probe-scraper

All issues in mozilla/probe-scraper

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.