mozilla / mozilla/probe-scraper
Remove dupe-metric hack
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 26
- Forks
- 73
- Avg merge
- 10h
- Merged PRs (30d)
- 3
Description
I added a hack to get firefox-desktop to work properly again:
https://github.com/mozilla/probe-scraper/blob/5717fce6ddcf5ce103cd7e47414c348547cf8651/probe_scraper/glean_checks.py#L19-L25
We should find a way that this is not necessary.
It shouldn't. The metric is moved from the app to the library.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with probe_scraper/glean_checks.py lines 19-25 and trace how the firefox-desktop metric is handled after moving from the app to the library. Determine how the duplicate-metric workaround can be removed without breaking probe scraping, then verify the resulting behavior with the relevant project checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100