mozilla / mozilla/probe-scraper

Improve dry-run for manual invocation

Open
#650 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
26
Forks
73
Avg merge
10h
Merged PRs (30d)
3

Description

When adding new libraries/apps we recommend doing a dry-run to ensure probe-scraper is working as expected and without issues.
This however requires deep knowledge about probe-scraper and how it works and with the push-mode it even requires a bit of understanding of that.

Just now we had an issue where a dry-run performed (#645) was fine, until it hit production.
Subsequently I found the "correct" dry-run (https://github.com/mozilla/probe-scraper/pull/649#issuecomment-1792138608) and that then failed the same as in production.

We should have some mode that automatically does the right thing (pick all dependencies) and document that. Maybe even be able to run that on CI.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the dry-run in #645 with the “correct” dry-run described in the #649 pull request comment, including the push-mode behavior. Define what automatic dependency selection should cover and document the reliable manual invocation; determine separately whether the same check can run in CI.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
ci-cd, cli
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.