mozilla / mozilla/probe-scraper

Expiry/Reminder bugs could be improved by putting the merge date in the title, setting status-firefoxNNN flags

Open
#547 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
26
Forks
73
Avg merge
10h
Merged PRs (30d)
3

Description

Expiry reminder bugs and emails typically look something like

Remove or update probes expiring in Firefox 112: WEBAUTHN_*

I posit they'd be catchier and more informative if they include the date that Firefox 112 starts, like

Remove or update probes expiring in Firefox 112: WEBAUTHN_* before Gecko version increases to 112 on 2023-02-13

(I'm open to improvements in the wording, but you get the idea). The merge date is present as NEXT_MERGE_DATE on product details which we already use for figuring out current and next Firefox versions.

Also, we can automatically set status flags to help sheriffs. For expiring version X, we can set status-firefox{X} to affected and status-firefox{X-1} and status-firefox{X-2} to unaffected. And for supported ESR versions Y (and, during overlap, Z) we can get Y from FIREFOX_ESR and Z from FIREFOX_ESR_NEXT from product details and set status-firefox-esr{Y} and status-firefox-esr{Z} to unaffected

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the existing lookup for current and next Firefox versions and the code that creates expiry reminder bugs and emails. Check the product-details Firefox versions JSON for NEXT_MERGE_DATE, FIREFOX_ESR, and FIREFOX_ESR_NEXT. Done means reminder titles include the relevant merge date and the requested Firefox and ESR status flags are set.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.