mozilla / mozilla/probe-scraper

Suggest to loosen the dependency on schema

Open
#531 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
26
Forks
73
Avg merge
10h
Merged PRs (30d)
3

Description

Hi, your project probe-scraper(commit id: 91632b0a7f292f08dc0997b753545590aa160824) requires "schema==0.7.1" in its dependency. After analyzing the source code, we found that the following versions of schema can also be suitable, i.e., schema 0.7.2, 0.7.3, 0.7.4, 0.7.5, since all functions that you directly (3 APIs: schema.And.init, schema.Optional.init, schema.Schema.init) or indirectly (propagate to 1 schema's internal APIs and 0 outsider APIs) used from the package have not been changed in these versions, thus not affecting your usage.

Therefore, we believe that it is quite safe to loose your dependency on schema from "schema==0.7.1" to "schema>=0.7.1,<=0.7.5". This will improve the applicability of probe-scraper and reduce the possibility of any further dependency conflict with other projects.

May I pull a request to further loosen the dependency on schema?

By the way, could you please tell us whether such an automatic tool for dependency analysis may be potentially helpful for maintaining dependencies easier during your development?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by locating the dependency declaration containing schema==0.7.1, then review the proposed compatible range. Done means the declaration accepts schema versions 0.7.1 through 0.7.5 without breaking the project’s existing checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Refactor
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.