mozilla / mozilla/probe-scraper

Mistakenly alerted about non-expiring metrics.

Open
#270 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
26
Forks
73
Avg merge
10h
Merged PRs (30d)
3

Description

Today the expiry mails complained about several metrics in engine-gecko:

- geckoview.build_id on 2021-02-01
- geckoview.version on 2021-02-01
- gfx.adapter.primary.description on 2021-02-01
- gfx.adapter.primary.device_id on 2021-02-01
- gfx.adapter.primary.driver_date on 2021-02-01
- gfx.adapter.primary.driver_files on 2021-02-01
- gfx.adapter.primary.driver_vendor on 2021-02-01
- gfx.adapter.primary.driver_version on 2021-02-01
- gfx.adapter.primary.ram on 2021-02-01
- gfx.adapter.primary.subsystem_id on 2021-02-01
- gfx.adapter.primary.vendor_id on 2021-02-01
- gfx.display.count on 2021-02-01
- gfx.display.primary_height on 2021-02-01
- gfx.display.primary_width on 2021-02-01
- gfx.status.compositor on 2021-02-01
- gfx.status.headless on 2021-02-01

These were all switched to never expire in bug 1687219, that landed 20 days ago.

Doesn't seem right that we send an email about that, but I'm not sure where to look at the moment.
Is the logic wrong and it skips never expiry if if already found an expiry?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the expiry-mail logic against the metrics listed in toolkit/components/telemetry/geckoview/streaming/metrics.yaml, focusing on the never-expire settings referenced in the issue. Done means metrics marked never no longer appear in expiry alerts, including the linked Gecko metrics.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.