mozilla / mozilla/probe-scraper

TypeError exceptions on missing version values

Open
#186 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
26
Forks
73
Avg merge
10h
Merged PRs (30d)
3

Description

Initially reported by @rtestard.

Currently https://probes.telemetry.mozilla.org/ results in a blank page (for some) after loading finishes.
This is probably due to these exceptions visible in the web console:

TypeError: "can't access property "version", e[a][n.last] is undefined"
    E utils.js:17
    y utils.js:60
    S searchResultsRow.jsx:41
    React 6
    unstable_runWithPriority scheduler.production.min.js:18
    React 6
    value main.jsx:451
    exports spread.js:25
react-dom.production.min.js:196:194
TypeError: "can't access property "version", e[a][n.last] is undefined"
    E utils.js:17
    y utils.js:60
    S searchResultsRow.jsx:41
    React 6
    unstable_runWithPriority scheduler.production.min.js:18
    React 6
    value main.jsx:451
    exports spread.js:25
react-dom.production.min.js:196:194
TypeError: "can't access property "version", e[a][n.first] is undefined"
    E utils.js:9
    y utils.js:60
    S searchResultsRow.jsx:41
    React 6
    unstable_runWithPriority scheduler.production.min.js:18
    React 6
    value main.jsx:451
    exports spread.js:25
react-dom.production.min.js:196:194
TypeError: "can't access property "version", e[a][n.first] is undefined"
    E utils.js:9
    y utils.js:60
    S searchResultsRow.jsx:41
    React 6
    unstable_runWithPriority scheduler.production.min.js:18
    React 6
    value main.jsx:451
    exports spread.js:25
react-dom.production.min.js:196:194
TypeError: "can't access property "version", e[a][n.first] is undefined"
    E utils.js:9
    y utils.js:60
    S searchResultsRow.jsx:41
    React 6
    unstable_runWithPriority scheduler.production.min.js:18
    React 6
    value main.jsx:451
    exports spread.js:25
react-dom.production.min.js:196:194
TypeError: can't access property "version", e[a][n.last] is undefined
utils.js:17:26

Initially most of the loaded files from the probe info service were cached (getting HTTP 304), but I also forced to clear the cache ("Disable cache" in the firefox devtools' network tab), so it seems to persist for the current set of data.

At the very least we should handle missing values better in the frontend.
At best we also fix the backend to not miss these values.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with utils.js at lines 9 and 17 and searchResultsRow.jsx at line 41, following the reported stack trace from the page rendering path. Reproduce the blank page at probes.telemetry.mozilla.org with missing version data and verify that the frontend no longer throws when those values are absent; investigate the backend only if the frontend evidence points there.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.