mozilla / mozilla/pdf.js

Intermittent failure in the `doesn't jump when moving selection` text layer integration test

Open
#21,978 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

intermittent test
Dominant language
JavaScript
Stars
53.9k
Forks
10.7k
Avg merge
18h 38m
Merged PRs (30d)
130

Description

This integration test fails intermittently in GitHub Actions. The last occurrence is in https://github.com/mozilla/pdf.js/actions/runs/34987052012/job/104443907967:

Failures:
1) Text layer Text selection using selection carets doesn't jump when moving selection
  Message:
    ProtocolError: session.new timed out. Increase the 'protocolTimeout' setting in launch/connect calls for a higher timeout if needed.
  Stack:
        at <instance_members_initializer> (file:///D:/a/pdf.js/pdf.js/node_modules/puppeteer-core/lib/puppeteer/common/CallbackRegistry.js:108:14)
        at new Callback (file:///D:/a/pdf.js/pdf.js/node_modules/puppeteer-core/lib/puppeteer/common/CallbackRegistry.js:112:16)
        at CallbackRegistry.create (file:///D:/a/pdf.js/pdf.js/node_modules/puppeteer-core/lib/puppeteer/common/CallbackRegistry.js:27:26)
        at BidiConnection.send (file:///D:/a/pdf.js/pdf.js/node_modules/puppeteer-core/lib/puppeteer/bidi/Connection.js:72:32)
        at Session.from (file:///D:/a/pdf.js/pdf.js/node_modules/puppeteer-core/lib/puppeteer/bidi/core/Session.js:70:49)
        at BidiBrowser.create (file:///D:/a/pdf.js/pdf.js/node_modules/puppeteer-core/lib/puppeteer/bidi/Browser.js:89:43)
        at FirefoxLauncher.createBiDiBrowser (file:///D:/a/pdf.js/pdf.js/node_modules/puppeteer-core/lib/puppeteer/node/BrowserLauncher.js:310:39)
        at process.processTicksAndRejections (node:internal/process/task_queues:104:5)
        at async FirefoxLauncher.launch (file:///D:/a/pdf.js/pdf.js/node_modules/puppeteer-core/lib/puppeteer/node/BrowserLauncher.js:143:27)
        at async PuppeteerNode.launch (file:///D:/a/pdf.js/pdf.js/node_modules/puppeteer-core/lib/puppeteer/node/PuppeteerNode.js:124:16)
        at async startBrowser (file:///D:/a/pdf.js/pdf.js/test/test.mjs:1122:19)
        at async UserContext.<anonymous> (file:///D:/a/pdf.js/pdf.js/test/integration/text_layer_spec.mjs:1271:19)

We should find out what's causing this and fix it because it seems to be the one of the last known intermittents we have left for the integration tests at the moment.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with test/integration/text_layer_spec.mjs at the failing test around line 1271, then read test/test.mjs around startBrowser at line 1122. Reproduce the GitHub Actions failure and trace the intermittent Puppeteer Firefox session.new timeout. Done means the test no longer intermittently fails in the integration-test runs.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.