Do we still need the separate `enableMerge` and `enableSplitMerge` options/preferences?
Open
Nobody has claimed this yet.
viewer
- Dominant language
- JavaScript
- Stars
- 53.9k
- Forks
- 10.7k
- Avg merge
- 18h 38m
- Merged PRs (30d)
- 130
Description
Given that these options/preferences control features that are highly related, do we still need them to be managed separately?
Or was this perhaps only necessary to allow the features to be rolled out gradually, since both are now enabled in Firefox?
/cc @calixteman
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Firefox PdfJsOverridePrefs.js reference in the issue and trace the enableMerge and enableSplitMerge preferences through pdf.js. Determine whether their separate management is still justified now that both features are enabled in Firefox; done means documenting and implementing a decided consolidation or retaining the split with a clear rationale.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100