mozilla / mozilla/grcov

Log file path on parser error?

Open
#953 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
1.4k
Forks
170
Avg merge
3d 10h
Merged PRs (30d)
4

Description

I'm hitting #908 running grcov on a build with many .gcda and .gcno files. The error looks like this:

[ERROR] A panic occurred at [...]/src/parser.rs:411: called `Result::unwrap()` on an `Err` value: Error("Unable to parse u64 from -35764", line: 1, column: 300810)

My problem is, grcov does not report on the file it is parsing when failing. It seems like --log-level DEBUG isn't helping and it's been a pain to locate that file. What about having grcov logging the name/path for the erroneous files it is parsing?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/parser.rs:411 and reproduce the parser failure with a build containing many .gcda and .gcno files. Check how --log-level DEBUG currently reports parsing, then make the erroneous file's name or path visible in the error output and verify it can identify the failing file.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.