mozilla / mozilla/fxa

Subscription management page uses CSS file with broken/out-of-date source map

Open
#16,013 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
685
Forks
237
Avg merge
2d 17h
Merged PRs (30d)
136

Description

Description

Poking at https://subscriptions.firefox.com/subscriptions in devtools, I'm noticing some CSS rules that are supposedly defined in .scss files, but if I click through, I end up seeing a completely different bit of CSS, and the CSS that I was looking for is nowhere to be found.

Steps to reproduce
  1. Have a subscription to e.g. Mozilla VPN service (probably required for this web page to load in such a way to trigger this bug, though I'm not sure)
  2. Right-click your username next to the profile avatar photo and choose "Inspect"
  3. Notice some CSS rule that's shown as being defined in a .scss file, e.g. the one for #fxa-settings-profile-header .card-header that starts with font-size: 20px;
  4. Click the name of the stylesheet next to that rule, in this case _avatar.scss:18
Expected result

I should end up looking at that rule in the .scss file.

Actual result

I ended up seeing some completely different line in the .scss file. The line that I quoted above, font-size: 20px, doesn't seem to exist at all in the .scss file.

Environment

Firefox Nightly 121 and Chrome 120 "dev" on Ubuntu 23.10

I think this sort of thing is an indication that we've got some invalid source-map info in our CSS file -- in this case, in https://subscriptions.firefox.com/static/css/main.0bd2978c.css which is the actual CSS file being used here.

┆Issue is synchronized with this Jira Task

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue at subscriptions.firefox.com/subscriptions, then inspect static/css/main.0bd2978c.css and its source map. Compare the mapping for the #fxa-settings-profile-header .card-header rule with _avatar.scss:18; done means DevTools opens the matching SCSS rule containing font-size: 20px.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, scss
Domain
build-system, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.