mozilla / mozilla/experimenter
Fail CI on feature manifest errors
Open
Beginner friendly
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 151
- Forks
- 229
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 212
Description
The manifesttool that loads and validates feature manifests will emit failure logs into the pr but exit 0 and not block the PR itself. We should change that to exit 1 so that the PR becomes blocked if a feature manifest fails validation.
┆Issue is synchronized with this Jira Task
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the manifesttool entry point and trace how feature manifest validation failures are logged and returned to CI. Reproduce a failing manifest validation, then verify that the command exits with status 1 and blocks the PR instead of succeeding with exit 0.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- ci-cd
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 72/100