mozilla / mozilla/code-review

Support reviewer groups in Github

Open
#3,395 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
67
Forks
52
Avg merge
3d 23h
Merged PRs (30d)
54

Description

Phabricator reporter is able to set specific reviewer groups on the revision when a specific linter fails.

Only the taskgraph diff task currently uses that feature.

The github reporter should support this feature, when the groups are available (ideally sharing the same name/slug as Phabricator)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the reviewer-group handling in bot/code_review_bot/report/phabricator.py at lines 174-195 and the taskgraph diff reference in bot/code_review_bot/tasks/tgdiff.py at line 87. Compare the GitHub reporter behavior discussed in pull request 3382. Done means the GitHub reporter uses available reviewer groups, ideally with the same names or slugs as Phabricator.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, python
Domain
devtools
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.