mozilla / mozilla/code-review

Make code-review bot complain loudly if a lint task does not produce a `mozlint.json`

Open
#2,684 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
67
Forks
52
Avg merge
3d 23h
Merged PRs (30d)
54

Description

In Bug 1956871, I'm trying to ensure that developers don't get surprised by failing lint tasks that aren't surfaced in Phab. That particular issue is due to the in-tree configuration of the linter, but the code-review bot does not help: it should complain that the lint task has not provided the required mozlint.json output rather than ignoring it. Can we do that?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading Bug 1956871 and tracing how the code-review bot handles lint tasks and their mozlint.json output. Confirm where a missing mozlint.json is currently ignored, then verify that the bot reports the missing required output instead.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.