mozilla / mozilla/code-review

replace warning about not all issues published with individual warnings why an issue did not get published

Open
#2,552 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
67
Forks
52
Avg merge
3d 23h
Merged PRs (30d)
54

Description

Currently, a warning gets logged if the amount of issues published is lower than the count of issues passed to the function to publish them. The case which prevent publishing get ignored (rust linting message starting a full stop) or log a warning except when the backend rejects the publication request.

Many instances of the current warning - 129 in total over the last 24h - could be from the rust linting.

Drop the count check of issues published but log a warning if the backend rejected the publication request.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the issue-publishing function in bot/code_review_bot/backend.py around the linked lines. Trace how rejected publication requests are handled, remove the aggregate count warning, and verify that a warning is emitted for backend rejection while ignored Rust linting cases do not produce that warning.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.