mozilla / mozilla/code-review

unexpected warning about failures introduced by the base revision

Open
#2,505 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
67
Forks
52
Avg merge
3d 23h
Merged PRs (30d)
54

Description

For this Phabricator revision, the code review posted warnings not introduced by the patch stack but which pre-existed for the autoland base revision.

The code review analysis for the autoland revision finished before the Try revision got pushed and the issues are stored in the database.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the code-review analysis timing with the autoland base and Try revisions linked in the issue, then trace how those results are stored in the database. Done means failures that pre-existed in the base revision are not reported as introduced by the patch stack, including when analysis finishes before the Try revision is pushed.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.