mozilla / mozilla/code-review

query for existing issues might fail silently and a new issue created for every issue detected by the task

Open
#2,270 4 comments 0 reactions 2 assignees View on GitHub

@vrigal is already working on this.

Since Sep 10, 2024.

Dominant language
Python
Stars
67
Forks
52
Avg merge
3d 23h
Merged PRs (30d)
54

Description

Log demonstrating issue

2024-07-23 06:00:42.000212 [INFO    ] [info     ] Checking for existing issues in the backend base_revision_changeset=ac4a1f84adfa69b77ccec3589f2a28ec7089fe10
2024-07-23 06:17:48.000023 [INFO    ] [info     ] Found 780 new issues (over 780 total detected issues) task=ZIJe3nlqQ4CvIivkOYtMNg

It took 17 min 06 s to query for known issues, yet no known issue has been detected by the task.

The time is close to 16 min 40 s, or 1000 s as a timeout.

If there is a performance issue which would cause the retrieval of the data to fail, the creation of tickets for every issue afterwards will further degrade the performance of the code review server.

Should the bulk of the known issues be served from a downloaded artifact and only the newest known issues be served as query of incremental data?

@La0 @marco-c

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.