mozilla / mozilla/code-review

Phabricator doesn't get notified of new tasks for revision

Open
#1,884 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
67
Forks
52
Avg merge
3d 23h
Merged PRs (30d)
54

Description

It can be seen in D187545 that there were no tasks associated with this revision.
Looking other the logs there was a local mercurial error even if the push was successful on the server side since the tasks for this differential were created, https://treeherder.mozilla.org/jobs?repo=try&revision=9086153f853187d4f43d03b5847042b879d0c6c7

Screenshot 2023-09-07 at 12 07 19

If mercurial is killed libmozevent doesn't capture the exception accordingly in order to also signal Phabricator that something happened. In this case this is a false positive issue since, as mentioned above the pushed was successful on the server.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing libmozevent's Mercurial error handling and how it signals Phabricator after a push. Reproduce or inspect the killed-Mercurial case described in the issue, then verify that a successful server-side push still notifies Phabricator without reporting a false failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.