mozilla / mozilla/code-review

clang-format linter has some rendering defects

Open
#1,814 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
67
Forks
52
Avg merge
3d 23h
Merged PRs (30d)
54

Description

It can be seen in D181494 that the second for loop has nothing to do in the current context and must be associated with line 248.
This is a rendering issue and should be addressed.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the rendering behavior shown in D181494, especially the comment at line 55, and trace the clang-format linter output around line 248. Compare the rendered context before and after the second for loop; done means that loop is associated with line 248 rather than appearing in the unrelated current context.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.