Reviewbot adding #taskgraph-reviewers to all patches in a stack that modify graph
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 67
- Forks
- 52
- Avg merge
- 3d 23h
- Merged PRs (30d)
- 54
Description
In https://github.com/mozilla/code-review/issues/1475 a rule was added to automatically #taskgraph-reviewers to a revision if the tgdiff task detects changes to the task graph.
In https://phabricator.services.mozilla.com/D177718, it correctly added #taskgraph-reviewers. But then it also added #taskgraph-reviewers for every child revision in the stack as well (in this case tens of CPP-only changes that are unrelated to CI).
Tbh, I question the premise of #1475 in the first place. In my mind #taskgraph-reviewers was meant to be a group for reviewing core Taskgraph changes, and not meant to get involved with the day to day adding / removing of tasks. My preference would be to simply revert that change.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the rule introduced in issue #1475 and the behavior shown in Phabricator D177718, focusing on how a stacked revision is evaluated. Confirm why #taskgraph-reviewers is added to unrelated child revisions; done means agreeing on and implementing either a narrower tagging rule or the proposed revert.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100