Decide if we want to fallback on "in-patch" instead of latest revision by date
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 30/100
Research direction
Start by tracing how the system selects the latest revision by date and how an in-patch revision could be selected when the parent revision is unavailable or unanalyzed. Use D3533 and the listed revisions as the validation case; done means the project has a decided fallback behavior that avoids overpublishing or misclassifying the issue.
Written by the indexing model from the issue text.
Description
With latest revision by date, in case the parent revision of a patch is not public or was not analyzed and stored in the backend for some reason, we can overpublish.
E.g. this happened in https://phabricator-dev.allizom.org/D3533, where the revision couldn't be found on the backend (since the revision is from staging m-c).
In ab25e7dfc0dc5bb8217fb436aac0957faf03a793, the issue was there.
In ffee8e3a7870875ab78af162638548f72cdabddf, the issue was not there anymore because it was fixed.
Andi's revision is based on ab25e7dfc0dc5bb8217fb436aac0957faf03a793, so the issue is still there in his revision.
When we get the latest revision by date, we get ffee8e3a7870875ab78af162638548f72cdabddf (or newer), and so the issue is not there
and so we consider the issue as new.
- Dominant language
- Python
- Stars
- 67
- Forks
- 52
- Avg merge
- 3d 23h
- Merged PRs (30d)
- 54
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from mozilla/code-review
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
mozilla/code-review#3399 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
mozilla/code-review#3666 ·
-
Remove the frontend Open
Difficulty 5/5 Over a week Newbie friendliness 30/100
mozilla/code-review#3648 · 3 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
mozilla/code-review#3640 ·
-
mozilla/code-review#3638 · 1 assignee ·
All issues in mozilla/code-review
Similar issues
-
area/auth bug comp/agent P3 platform/discord type/security
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
NousResearch/hermes-agent#117848 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
bancolombia/sentinel#23 ·
-
test md OpenCI
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
integration:quickjs org:external priority:backlog topic:code-interpreter topic:middleware type:feature
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
langchain-ai/deepagents#6450 ·
-
bug client
Difficulty 2/5 1-3 hours Newbie friendliness 88/100