Build error email should be sent to the author of the revision rather than the author of the commit attached to the revision
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 67
- Forks
- 52
- Avg merge
- 3d 23h
- Merged PRs (30d)
- 54
Description
We are currently using the commit's author email, https://github.com/mozilla/code-review/blob/2e460a573115818f81872587a032420a9102fa9c/bot/code_review_bot/report/mail_builderrors.py#L86, but it could be wrong sometimes (e.g. for https://phabricator.services.mozilla.com/D176405, https://hg.mozilla.org/mozilla-central/rev/6085d4c, it was kk@kk.kk).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in bot/code_review_bot/report/mail_builderrors.py at line 86 and inspect how the revision and commit author emails are obtained. Use the linked Phabricator revision and Mercurial changeset as the example; done means build-error mail targets the revision author rather than the attached commit author.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100