For `NoticeTask` verify is the source of notice is in the current patch
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 67
- Forks
- 52
- Avg merge
- 3d 23h
- Merged PRs (30d)
- 54
Description
In https://phabricator.services.mozilla.com/D128430 code-review-bot reported that the documentation has been touched, which is wrong but looking on the push stack we can see that there is at least on push that modifies the documentation.
This is because when notices list is built different notice tasks don't take into account if the notice originated from the current patch or not.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in bot/code_review_bot/workflow.py around line 356, where the notice list is built, and trace how NoticeTask verifies a notice's source. Compare the notices with the current patch in the linked push stack. Done means notices from earlier pushes are not reported as originating from the current patch, while notices actually introduced by it remain included.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100