The apply pending actions can double-post when having concurrent requests
Open
Nobody has claimed this yet.
hackbot
- Dominant language
- Python
- Stars
- 570
- Forks
- 351
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 65
Description
[!NOTE]
This did not happen yet, so no examples, but in theory it is a bug that needs to be fixed.
The apply_all_pending method reads a run's not-yet-applied rows, then dispatches and commits each one, with no lock. Two concurrent calls both see the same pending rows and both dispatch them, so the same Bugzilla comment can be posted twice.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the apply_all_pending method and trace how it reads pending rows, dispatches each action, and commits the result. Reproduce or reason through two concurrent calls, then verify that each pending row is dispatched once and cannot produce duplicate Bugzilla comments.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100