mozilla / mozilla/bugbug

Convert Hackbot actions to be classes instead of dicts

Open
#6,829 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

hackbot
Dominant language
Python
Stars
570
Forks
351
Avg merge
2d 13h
Merged PRs (30d)
65

Description

As a follow up, we could covert that action to be a class instead of dict (maybe Pydantic model), then the confirmation could be a method on that action class.

Originally posted by @suhaibmujahid in https://github.com/mozilla/bugbug/pull/6826#pullrequestreview-5181208098

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the current Hackbot action dictionaries and the follow-up context in pull request #6826. Determine which action data and confirmation behavior need to move into classes, with a Pydantic model as a possible approach. Done means Hackbot actions use the new class representation and confirmation is handled by the action itself.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.